David Knupp has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4873/1/tests/comparison/db_connection.py File tests/comparison/db_connection.py: PS1, Line 538: return () What am I missing here? This doesn't do what the docstring claims -- it only returns an empty tuple. http://gerrit.cloudera.org:8080/#/c/4873/1/tests/metadata/test_show_create_table.py File tests/metadata/test_show_create_table.py: PS1, Line 241: TestInfraCompat I have wondered whether we should create a new directory under ${IMPALA_HOME}/tests called "infra", as a place to keep (an hopefully add) tests of the infrastructure itself. What do you think of that idea? -- To view, visit http://gerrit.cloudera.org:8080/4873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib654b6cd0e8c2a172ffb7330497be4d4a751e6e5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Harrison Sheinblatt <h...@hotmail.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
