Tim Armstrong has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4896/3/be/src/service/impala-server.h File be/src/service/impala-server.h: PS3, Line 675: The lock must be acquired before 'query_exec_state_map_lock_' or : /// QueryExecState::lock_ if they will be held simulataneously. > Instead of just having this above this lock, it would be better to spell ou Done -- To view, visit http://gerrit.cloudera.org:8080/4896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I785fea0163a90d0633fb6ed77ec7c6882ab5c110 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
