Zoltan Ivanfi has posted comments on this change.

Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer
......................................................................


Patch Set 2:

Hi Tim,

Sorry for being unresponsive, I was on vacation for a week.

I would vote for opening a follow-up JIRA for test coverage, as creating such a 
test file will be more complicated than identifying and fixing this issue was. 
However, we have seen this happening in the wild, so this is certainly not only 
a theoretical, but a real issue.

-- 
To view, visit http://gerrit.cloudera.org:8080/4835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52e1b1354e9ea056b49331e75e53759952a81b76
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi <z...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <z...@cloudera.com>
Gerrit-HasComments: No

Reply via email to