Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4873/2/tests/comparison/common.py File tests/comparison/common.py: PS2, Line 527: updatable_columns > I don't agree. I think a name like "non_pk_cols" can end up leading to conf Sure, I don't feel strongly, but I don't think of it being weird for other table types -- they really have no notion of a primary key, so all cols are not PK cols. It's like saying we can't ask if a col is decimal or not just because a particular storage format doesn't support decimal. Further, it is common to reason about the abstraction of a "Table" as something having PKs or not, whereas 'updatable' isn't a property that is common on this abstraction. Anyway, that's just what I was thinking. I'm fine either way. -- To view, visit http://gerrit.cloudera.org:8080/4873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib654b6cd0e8c2a172ffb7330497be4d4a751e6e5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Harrison Sheinblatt <h...@hotmail.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
