Tim Armstrong has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4941/1/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: Line 334: FunctionContext* fn_ctx = ctx->fn_context(fn_context_index_); > Sounds good. Might still be good to add in the comment here that the underl Done -- To view, visit http://gerrit.cloudera.org:8080/4941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I705d271814cb1143f67d8a12f4fd87bab7a8e161 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes