Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: Line 437: BlockLocation[] locations = fs.getFileBlockLocations(file, 0, file.getLen()); > still using the old API? I don't think this change is complete. This call stack need to be moved to the new API as well. com.cloudera.impala.catalog.TableLoader.load(Db,String) com.cloudera.impala.catalog.HdfsTable.load(boolean,IMetaStoreClient,Table) com.cloudera.impala.catalog.HdfsTable.load(boolean,IMetaStoreClient,Table,boolean,boolean,Set) com.cloudera.impala.catalog.HdfsTable.loadAllPartitions(List,Table) com.cloudera.impala.catalog.HdfsTable.createPartition(StorageDescriptor,Partition,Map) com.cloudera.impala.catalog.HdfsTable.updatePartitionFds(Path,boolean,HdfsFileFormat,Map) com.cloudera.impala.catalog.HdfsTable.loadBlockMetadata(FileSystem,FileStatus,HdfsPartition$FileDescriptor,HdfsFileFormat,Map) org.apache.hadoop.hdfs.DistributedFileSystem.getFileBlockLocations(FileStatus,long,long) org.apache.hadoop.hdfs.DistributedFileSystem.getFileBlockLocations(Path,long,long) org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystem,Path) org.apache.hadoop.hdfs.DistributedFileSystem$1.doCall(Path) org.apache.hadoop.hdfs.DistributedFileSystem$1.doCall(Path) org.apache.hadoop.hdfs.DFSClient.getBlockLocations(String,long,long) org.apache.hadoop.hdfs.DFSClient.getLocatedBlocks(String,long,long) org.apache.hadoop.hdfs.DFSClient.callGetBlockLocations(ClientProtocol,String,long,long) -- To view, visit http://gerrit.cloudera.org:8080/4914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbff94cef9a9db7b3945f8e7b0286866d2cc3b61 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes