Henry Robinson has posted comments on this change. Change subject: IMPALA-4437: hit DCHECK in buffered-block-mgr-test ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4973/1/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: PS1, Line 983: if (!buffer->is_client_buffer()) I don't know this code very well. Could you DCHECK() on this in FreeBufferMemory()? The other callsites seem to guard the call to FreeBufferMemory() with the same condition. -- To view, visit http://gerrit.cloudera.org:8080/4973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7e8ffdbec341f6ffbc310fb29df63ab45fed545 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: Yes
