Alex Behm has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/4863/9/tests/query_test/test_insert_behaviour.py File tests/query_test/test_insert_behaviour.py: Line 488: import os why? Line 491: table_location = DEFAULT_FS + "/" + table_path I'm confused. Doesn't get_fs_path() do the right thing? Why do we have to add this DEFAULT_FS prefix? Line 550: table, table_location) indent 4 -- To view, visit http://gerrit.cloudera.org:8080/4863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
