Thomas Tauber-Marshall has posted comments on this change. Change subject: Improve Kudu UPSERT test coverage ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4953/2/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: PS2, Line 341: test_section : s > Right now I think this would need more work to support both a RESULTS secti Done PS2, Line 357: dml_results_query = "select * from %s limit 1000" % \ > remove; this is already defined above on l310 Done PS2, Line 359: dml_result = self.__execute_query(target_impalad_client, dml_results_query) : verify_raw_results > 1) add a DCHECK that ERRORS isn't specified because we shouldn't be checkin Done -- To view, visit http://gerrit.cloudera.org:8080/4953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9e7afbef60186edb00a9d11fbe5a8c64931add6 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
