Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable ......................................................................
Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/4867/8/be/src/util/backend-config-util.cc File be/src/util/backend-config-util.cc: Line 38: DEFINE_bool(load_catalog_at_startup, false, "if true, load all catalog data at startup"); Where are these DEFINEs currently? Shouldn't these all be DECLARE, otherwise we'll have two definitions. http://gerrit.cloudera.org:8080/#/c/4867/8/be/src/util/backend-config-util.h File be/src/util/backend-config-util.h: Line 27: class BackendConfigUtil { no need for a class, just use a function http://gerrit.cloudera.org:8080/#/c/4867/8/fe/src/main/java/org/apache/impala/service/BackendConfig.java File fe/src/main/java/org/apache/impala/service/BackendConfig.java: Line 43: public long getReadSize() { single line where it fits -- To view, visit http://gerrit.cloudera.org:8080/4867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yonghyun Hwang <yongh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Huaisi Xu <h...@cloudera.com> Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: Yonghyun Hwang <yongh...@cloudera.com> Gerrit-HasComments: Yes
