Michael Brown has posted comments on this change. Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py File tests/conftest.py: PS1, Line 331: timeout = __call_cls_method_if_exists(request.cls, "get_conn_timeout") or 45 Instead of hard coding 45 in several places, can you create a constant for use in all the places 45 is hardcoded? Also please have a comment pointing to the Jira so a user understands why it's here. http://gerrit.cloudera.org:8080/#/c/5040/1/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: PS1, Line 205: return 60 * 5 # 5 minutes Can you mention the Jira here, so that when someone else comes across this code, he has a reference for the intent? -- To view, visit http://gerrit.cloudera.org:8080/5040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2727c27ff66140ac4043bcad332cd4e1d72b255f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
