Alex Behm has posted comments on this change.

Change subject: IMPALA-4444: Transfer row group resources to row batch on scan 
failure
......................................................................


Patch Set 1:

Code changes lgtm.

Is it reasonable to add a test for this case? Maybe we could create a file with 
two row groups, the second of which is corrupt. Other ideas?

-- 
To view, visit http://gerrit.cloudera.org:8080/5052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id70df470e98dd96284fd176bfbb946e9637ad126
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-HasComments: No

Reply via email to