Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5026/4/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: Line 920: | KW_ALTER KW_TABLE table_name:table KW_DROP opt_kw_column IDENT:col_name > Sorry, don't understand the problem in this case. col_name is an identifier Pretty much anywhere, unfortunately. In this example, you cannot write: ALTER TABLE mytable DROP default; you have to say ALTER TABLE mytable DROP `default`; so "default" being a keyword leaks to all places that accept IDENT -- To view, visit http://gerrit.cloudera.org:8080/5026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727b9ae1b7b2387db752b58081398dd3f3449c02 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
