Alex Behm has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity. ......................................................................
Patch Set 1: (1 comment) Made slight modifications to: - provide a static validity check in NumericLiteral itself - augment check for the negative zero case Please take another quick look. http://gerrit.cloudera.org:8080/#/c/5050/1/fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java File fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java: Line 38: * TODO: BigDecimal cannot represent special float values like NaN and infinity. > do we really want to do this at any point in the future? Yea, probably not. Converted TODO to regular comment. -- To view, visit http://gerrit.cloudera.org:8080/5050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8243b2ee9fa9c470d078b385583f2f48b606a230 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
