Tim Armstrong has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5105/2/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: Line 161: if (state->CodegenDisabled()) { Shouldn't this be COdegenDisabledByQueryOption() to match the message? http://gerrit.cloudera.org:8080/#/c/5105/2/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: PS2, Line 113: Interanl Internal PS2, Line 132: too_many_args too_many_args_to_interpret? PS2, Line 156: AddUdfToCodegen Udf seems like a bit of a misnomer, since it may be a builtin. Maybe "AddScalarFnToCodegen()"? http://gerrit.cloudera.org:8080/#/c/5105/2/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: PS2, Line 318: disable_codegen It would be good if we had a different name to distinguish this from the other disable_codegen flag. E.g. hint_disable_codegen? http://gerrit.cloudera.org:8080/#/c/5105/2/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: PS2, Line 42: exec_single_node_option=[100] It seems like we'd want to test with the single node option both enabled and disabled -- To view, visit http://gerrit.cloudera.org:8080/5105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b6a9ed723c64ba21b861608583cc9b6607d3397 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
