Attila Jeges has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present ......................................................................
Patch Set 3: > > Thanks!Do you think I should add some code to catalog to validate > the > > value of 'initial_hms_cnxn_timeout_s'? What would be the > acceptable > > range? > > You could validate that it was > 0, but otherwise I don't think you > should put a bound on it. Users may want to wait effectively > forever, and I can see them setting 9999999999 as a value to > simulate that. > > > Adding this config parameter to the CM UI is another issue. Do > you think it should be added for the 5.10 release or it is not > that urgent? I guess, the default value is reasonable for most > users and they can always set it as a safety valve if they have to. > > Sounds like you're talking about a Cloudera release. Reminder that > this is the Apache Impala project - vendor specific concerns should > be discussed elsewhere. Thanks for the review, I've added the > 0 check. Could you add a +2 once more? -- To view, visit http://gerrit.cloudera.org:8080/5095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I546d8fe9836004832ae40110c9fe22b3e704e11b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: No
