Michael Ho has posted comments on this change. Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4833/3/be/src/exec/filter-context.cc File be/src/exec/filter-context.cc: PS3, Line 137: LlvmCodeGen::FnPrototype prototype(codegen, "FilterContextEval", codegen->boolean_type()); long line. http://gerrit.cloudera.org:8080/#/c/4833/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS3, Line 286: considered total_possible PS3, Line 700: alwaysinline noinline -- To view, visit http://gerrit.cloudera.org:8080/4833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27114869840e268d17e91d6e587ef811628e3837 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
