Michael Brown has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model ......................................................................
Patch Set 1: Code-Review+1 (3 comments) Thanks for the review. Carry +1 http://gerrit.cloudera.org:8080/#/c/5162/1/tests/comparison/leopard/custom_pickle.py File tests/comparison/leopard/custom_pickle.py: > std file header? Done PS1, Line 8: : Thanks to https://wiki.python.org/moin/UsingPickle/RenamingModules > are we sure licensing is OK? How do I go about finding this out? I had previously looked for copyrights on this page, or on code snippets from the wiki generally, and found none. (The only copyright I found was for MoinMoin wiki itself, which isn't what I need.) http://gerrit.cloudera.org:8080/#/c/5162/1/tests/comparison/query.py File tests/comparison/query.py: PS1, Line 43: Since all supported : queries may have a WITH clause, getting table expressions from the WITH clause is : supported here. > FYI, other DML statements won't support WITH clauses. Done. We talked offline about this and it makes sense to leave this as-is, the reason being that we could eventually support WITH in DELETE and UPDATE, just not now. Since UPSERT is "mostly" INSERT, it currently supports WITH already. -- To view, visit http://gerrit.cloudera.org:8080/5162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e24da78c49e908449b35f0a6276ebe4236ddba Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
