Tim Armstrong has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5127/4/be/src/scheduling/simple-scheduler.cc File be/src/scheduling/simple-scheduler.cc: Line 261: if (new_backend_config->NumBackends() > 0 > The reasoning behind the check was that it prevents empty messages from the Hmm, yeah if it's possible to get a heartbeat before the initial statestore message that could cause other problems. E.g. if you have a delta with a single subscriber in the first heartbeat, then you could end up scheduling everything on that node. Line 264: new_backend_config->AddBackend(local_backend_descriptor_); > So far current_membership_ has mirrored the statestore's view. Adding the l We could just combine this check and the current_membership_ check below, right? It seems ok to preemptively add the local backend here at the same time as we add it to be sent to the statestore. -- To view, visit http://gerrit.cloudera.org:8080/5127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e1196a2fa47e5954c4a190aa326c135d039a77f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
