Alex Behm has posted comments on this change. Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. ......................................................................
Patch Set 2: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/5125/2//COMMIT_MSG Commit Message: PS2, Line 10: Show column encoding and compression once available > No longer relevant, no? Done http://gerrit.cloudera.org:8080/#/c/5125/2/fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java File fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java: PS2, Line 39: import org.apache.kudu.client.shaded.com.google.common.base.Strings; > :) looks as if two import statements got merged into one. Anyways, replace Wow, really weird. Fixed. PS2, Line 278: else { : defaultValCol.setString_val(kuduColumn.isNullable() ? "NULL" : ""); : } > The Kudu team is working on removing this constraint (i.e. either default Leaving the default value blank now. http://gerrit.cloudera.org:8080/#/c/5125/2/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: PS2, Line 459: [("b", "string", "", "true", "false", "", "AUTO_ENCODING", "DEFAULT_COMPRESSION", "0"), : ("c", "string", "", "false", "false", "", "AUTO_ENCODING", "DEFAULT_COMPRESSION", "0")] > long lines Done -- To view, visit http://gerrit.cloudera.org:8080/5125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83c91b540bc6d27cb4f21535fe12f3f8658c233e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
