Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory ......................................................................
Patch Set 8: (2 comments) Sorry about that, lost track of those comments. http://gerrit.cloudera.org:8080/#/c/4956/7/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 1073: module_ = NULL; > What about destroying fns_to_jit_compile_ here too as it may still contain Done http://gerrit.cloudera.org:8080/#/c/4956/8/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: PS8, Line 467: if > is Done -- To view, visit http://gerrit.cloudera.org:8080/4956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10015b49da182cb181a653ac8464b4a18b71091 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Silvius Rus <s...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
