Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4410: Safer tear-down of RuntimeState ......................................................................
IMPALA-4410: Safer tear-down of RuntimeState * Add RuntimeState::Close() which is guaranteed to release resources safely, rather than having PFE::Close() do the same piecemeal. * Fix for crash where PFE::Prepare() fails before descriptor table is created. * Remove some dead code from TestEnv, and rename some methods for clarity. Testing: Found by debug-actions, which has a reproducible test where PFE::Prepare() fails. Manually tested on master. Change-Id: Ie416e4d57240142bf685385299b749c3a6792c45 Reviewed-on: http://gerrit.cloudera.org:8080/4893 Tested-by: Internal Jenkins Reviewed-by: Henry Robinson <he...@cloudera.com> --- M be/src/exec/hash-table-test.cc M be/src/runtime/buffered-block-mgr-test.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/plan-fragment-executor.cc M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/runtime/test-env.cc M be/src/runtime/test-env.h M be/src/service/fe-support.cc A be/src/util/scope-exit-trigger.h 10 files changed, 111 insertions(+), 72 deletions(-) Approvals: Henry Robinson: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie416e4d57240142bf685385299b749c3a6792c45 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
