David Knupp has posted comments on this change.

Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading 
tpcds.store_sales
......................................................................


Patch Set 2:

Just to clarify, because I think it might be confusing to people not familiar 
with the 3 code paths Harrison referenced:

1. Originally "data load" meant generating all data from scratch. Doesn't 
assume loading anything from a snapshot file. This is the general use case, and 
is what an external contributor would need to do.

2. It can also mean that we copy data to HDFS from a snapshot file, but we 
don't restore the metadata from a snapshot. This is the case that currently 
applies to loading Impala's test data to a cluster within Cloudera's testing 
infrastructure, but theoretically this could be done elsewhere.

3. Finally, the case by which *both* HDFS and metadata DB are reconstituted 
from snapshot files -- though some tweaking of the metadata is still usually 
required. This is most commonly used by developers who have access to the 
Cloudera internal resources.

Just wanted to clarify that.

-- 
To view, visit http://gerrit.cloudera.org:8080/5177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaae97d1d44201aeeacacdd39adbae35753512950
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Harrison Sheinblatt <h...@hotmail.com>
Gerrit-HasComments: No

Reply via email to