Marcel Kornacker has posted comments on this change. Change subject: Avoid std::function when possible. ......................................................................
Patch Set 1: > > I do not find it more readable, but I find it to be readable > enough; I think the readability delta is a good price to pay to > avoid boxing up a lambda. > > Could you be more specific about the drawbacks? We've spoken about > heap allocation; personally I don't think that's an issue because > it's not unusual, but perhaps that's a dealbreaker for you. > Otherwise I know you consider it 'overkill', but I don't yet know > why. Perhaps there's something about this class in particular that > makes it a bad choice for std::function? Heap allocation is actually an issue, because it doesn't go with how we (eventually) want to do memory management and reservations. I understand that we do this elsewhere, by virtue of using STL, but we shouldn't add to it. Throwing in the c'tor is also not okay. -- To view, visit http://gerrit.cloudera.org:8080/5230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9dc034c2e094ea7f87f78d8d9101a71d8d2e295 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: No
