Alex Behm has posted comments on this change. Change subject: IMPALA-4458: Fix resource cleanup of cancelled mt scan nodes. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5274/2/be/src/exec/parquet-column-readers.h File be/src/exec/parquet-column-readers.h: Line 232: virtual void Close(RowBatch* row_batch) = 0; > Doc that row_batch can be NULL. Missed this the first time around, sorry. Done. -- To view, visit http://gerrit.cloudera.org:8080/5274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib32f87b3289ed9e8fc2db0885675845e11207438 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
