Dan Hecht has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5288/1/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 139: kudu::client::KuduScanner::READ_AT_SNAPSHOT), "Could not set scanner ReadMode."); rather than relying on the kudu default, do you think we should always call SetReadMode() with the appropriate flag depending on the Impala setting? Seems more explicit that way. Also, if we plan to make this the default soon, do you think we should make the option have the opposite polarity (i.e. read_latest -- so the default becomes 'false' in the long term)? Alternatively, is there any chance there would be more than two values for the read mode in the future? In that case, maybe the option should be --kudu_read_mode={snapshot, latest}. -- To view, visit http://gerrit.cloudera.org:8080/5288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003aba410548bc9158d1e11abbdcf710c31a82ff Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
