Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc ......................................................................
IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc FLAGS_stress_free_pool_alloc is a gflag for simulating malloc failure in debug builds. If set, FreePool::Allocate() and FreePool::Reallocate() will return NULL on every FLAGS_stress_free_pool_alloc allocations. The problem is that the counter for tracking number of allocations is updated racily by multiple threads, leading to non-determinism and flaky tests. This change fixes the problem by making the counter an AtomicInt32. Change-Id: I373035d209a0f3477650336ee6da458fa289dbe0 Reviewed-on: http://gerrit.cloudera.org:8080/5281 Reviewed-by: Jim Apple <jbapple-imp...@apache.org> Reviewed-by: Dan Hecht <dhe...@cloudera.com> Tested-by: Internal Jenkins --- M be/src/common/atomic.h M be/src/runtime/CMakeLists.txt A be/src/runtime/free-pool.cc M be/src/runtime/free-pool.h 4 files changed, 41 insertions(+), 6 deletions(-) Approvals: Jim Apple: Looks good to me, but someone else must approve Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I373035d209a0f3477650336ee6da458fa289dbe0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
