Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5162/7/tests/comparison/query.py File tests/comparison/query.py: PS7, Line 56: self.with_clause.table_exprs > I talked to Taras separately and the concern here is, does the += modify th I just tried this: class A(object): def __init__(self): self._x = [1, 2, 3] @property def x(self): return self._x a = A() lst = a.x lst.extend([5, 6]) print a.x # prints [1, 2, 3, 5, 6] So looks like @property does not return a copy. -- To view, visit http://gerrit.cloudera.org:8080/5162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e24da78c49e908449b35f0a6276ebe4236ddba Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
