Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5343/1/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: Line 143: /// the time falls into 00:00:00..23:59:59.999999999 range. > Stale comment - we don't validate time. Done -- To view, visit http://gerrit.cloudera.org:8080/5343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieaab5d33e6f0df831d0e67e1d318e5416ffb90ac Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes