Alex Behm has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5364/1/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: Line 432: * the alter table operation is finished or until the operation timeout is reached. > If the function returns false it means it timed out. I think we should distinguish those cases for supportability reasons. Line 435: public static void alterKuduTable(KuduTable tbl, AlterTableOptions ato, String errMsg) > Hm, not sure how this would work. For the rename you need to call the opera Ahh you are right, got it. -- To view, visit http://gerrit.cloudera.org:8080/5364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385bce66691ae9040e72f97557e1bba31009e36b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
