Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4585: Replace file paths with __HDFS_FILENAME__ in expected exceptions ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5372/1//COMMIT_MSG Commit Message: Line 9: Recently we introduced a change where we should replace file paths in > Can you point me to the change so I can understand why we made it? It was introduced by me here: https://github.com/cloudera/Impala/commit/0e67a56282ebd9c931ed7317311124dde0ca5201#diff-bb8f84b351f4f7e3c5adb6787ab37038R7 For my tests we don't know what path of the HDFS file will be upfront, that's why I added the template replacement in the CATCH section of the test file. (It's already being done in other sections) -- To view, visit http://gerrit.cloudera.org:8080/5372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0f6ae8dea7ac4cdaf0c61ebd8f0c589c353a96e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
