Dan Burkert has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5382/1/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: PS1, Line 287: DISTRIBUTE BY > This is no longer true. The clause is "PARTITION BY". Done http://gerrit.cloudera.org:8080/#/c/5382/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: PS1, Line 1964: into 2 > Is this valid syntax? no this was a bad find/replace. http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/db_connection.py File tests/comparison/db_connection.py: PS1, Line 799: DISTRIBUTE > Hm, that should be PARTITION. Done http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/tests/test_cursor.py File tests/comparison/tests/test_cursor.py: PS1, Line 79: DISTRIBUTE > PARTITION Done PS1, Line 83: DISTRIBUTE > PARTITION Done -- To view, visit http://gerrit.cloudera.org:8080/5382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
