Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2864: Ensure that client connections are closed after a failed Open() ......................................................................
Patch Set 3: Code-Review+2 (2 comments) Rebase. Carry +2. http://gerrit.cloudera.org:8080/#/c/5385/2/be/src/rpc/thrift-client.cc File be/src/rpc/thrift-client.cc: PS2, Line 46: > confusing since it talks about "socket' when the code does something to the Done http://gerrit.cloudera.org:8080/#/c/5385/2/be/src/rpc/thrift-client.h File be/src/rpc/thrift-client.h: Line 55: /// If Open() fails, the connection remains closed. > Is "connection" and "socket" synomymous, or not? Everwhere else here we say They are synonymous in this context at least. Done. -- To view, visit http://gerrit.cloudera.org:8080/5385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7e883d8224304ad13a051f595d0e8abf4f9671e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
