Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. ......................................................................
Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/4418/6/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS6, Line 509: qs = nullptr; > superfluous, since it is never read again. it still feels safer to reset it, the logic below can change. http://gerrit.cloudera.org:8080/#/c/4418/6/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: PS6, Line 76: uery_id=" << param > beware that this can change between line 72 and now. Just store the result Done http://gerrit.cloudera.org:8080/#/c/4418/7/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 83: /// rpc. > Okay, yes, that's what was discussed. And yes, the sentence below (that you Done http://gerrit.cloudera.org:8080/#/c/4418/6/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: PS6, Line 89: // Helper function to translate between Beeswax and HiveServer2 type : static TOperationState::type QueryStateToTOperationState( : const beeswax::QueryState::type& query_state) { : switch (query_state) { : case beeswax::QueryState::CREATED: return TOperationState::INITIALIZED_STATE; : case beeswax::QueryState::RUNNING: return TOperationState::RUNNING_STATE; : case beeswax::QueryState::FINISHED: return TOperationState::FINISHED_STATE; : case beeswax::QueryState::EXCEPTION: return TOperationState::ERROR_STATE; : default: return TOperationState::UKNOWN_STATE; : } : } > While you're here, put in anonymous namespace. static will work just fine here. http://gerrit.cloudera.org:8080/#/c/4418/6/be/src/util/thread.h File be/src/util/thread.h: PS6, Line 146: /// Starts a detached thread running 'functor' and returns immediately. : static void StartDetachedThread(con > What's a detached thread? Why doesn't this method register threads so that i reverted the changes to thread.{cc,h}. -- To view, visit http://gerrit.cloudera.org:8080/4418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I962ae6b7cb7dc0d07fbb8f70317aeb01d88d400b Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
