Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4611: Checking perms on S3 files is a very expensive no-op ......................................................................
Patch Set 1: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/5449/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: Line 797: * from that. Expand the comment to mention that for S3 it always returns READ/WRITE access. PS1, Line 802: getPermissions nit: when referencing functions use parentheses (getPermissions()). PS1, Line 806: TODO: Revisit if the S3A connector is updated to be able to manage S3 object : // permissions. If there is a JIRA for this, can you add it here? -- To view, visit http://gerrit.cloudera.org:8080/5449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9d1072c185a6162727019cdf1cb34d7f3f1c75c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
