Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5505/1/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: PS1, Line 388: Preconditions.checkNotNull(value == null); > Shouldn't this be checkNotNull(value)? It depends, if you want this Precondition to do anything then yes :) Good catch. Fixing this too. -- To view, visit http://gerrit.cloudera.org:8080/5505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf2c10a326373ad80aef51a85cec64071daefa7b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
