Tim Armstrong has posted comments on this change. Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5523/1/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: Line 670: // interface only loads this format from a file. We don't want to raise This comment about raising an error is wrong - looks like I missed updating it when I changed this code. PS1, Line 673: FLAGS_local_library_dir We should update the command line option info string to reflect that it's now used for an additional purpose. Line 678: return Status(Substitute("Could not create temporary timezone file: $0", filestr)); Augment comment to mention --local_library_dir. E.g. "Check that --local_library_dir is writable by Impala". -- To view, visit http://gerrit.cloudera.org:8080/5523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
