Alex Behm has posted comments on this change. Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5137/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java File fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java: Line 74: TableRef tableRef = new TableRef(tableName_.toPath(), null, Privilege.ALTER); > yeah, it's really a dillema here. My rough idea is to loop in the old parti I thought about this issue a little more, but still have not reached a conclusion as to what we should do. The possible double loading/refresh seems like a problem. I agree we could treat the fully-specified single-partition case specially. However, it's not clear how useful the REFRESH based on predicates would be given the following difficulty. Our existing REFRESH can discover new partitions. A REFRESH based on predicates would not be able to easily discover partitions that satisfy the predicates. Seems like the predicate evaluation would need to be moved into the catalogd to support partition discovery. I still need to keep thinking and rope in some other people, but wanted to dump my thoughts in case you have ideas. -- To view, visit http://gerrit.cloudera.org:8080/5137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4e46ec0a63b46e485141290268d019c3dd15c7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird <amosb...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Amos Bird <amosb...@gmail.com> Gerrit-HasComments: Yes
