Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE. ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5556/1//COMMIT_MSG Commit Message: Line 15: version (i.e., without incrementing the catalog version). Nice find :) http://gerrit.cloudera.org:8080/#/c/5556/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: Line 1070: catalog_.removeDataSource(params.getData_source()); Same. Line 2080: catalog_.renameTable(tableName.toThrift(), newTableName.toThrift())); Should we update this as well? renameTable() could potentially return null in which case , we are adding some weird new TCatalogObject(TCatalogObjectType.TABLE, Catalog.INITIAL_CATALOG_VERSION); Line 2658: role = new Role(createDropRoleParams.getRole_name(), Sets.<String>newHashSet()); Shouldn't this be updated as well? -- To view, visit http://gerrit.cloudera.org:8080/5556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb1f31eb2ecf05b9b51ef4e12e6bb78f44d0cf84 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-HasComments: Yes
