Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4689: Fix computation of last active time ......................................................................
IMPALA-4689: Fix computation of last active time The last active time in impala-server.cc#L1806 is in milliseconds, but the TimestampValue c'tor expects seconds. This change also renames some variables to make their meaning more explicit, aiming to prevent similar bugs in the future. This change also fixes a bug that occurred when during startup of the local minicluster the operating system PIDs would wrap around. This way the first impalad would not be the one with the smallest PID and ImpalaCluster.get_first_impalad() would return the wrong one. I ran git-clang-format on the change. Change-Id: I283564c8d8e145d44d9493f4201555d3a1087edf --- M be/src/service/impala-http-handler.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/service/query-exec-state.cc M be/src/service/query-exec-state.h M tests/common/impala_cluster.py M tests/custom_cluster/test_query_expiration.py 7 files changed, 35 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/5546/2 -- To view, visit http://gerrit.cloudera.org:8080/5546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I283564c8d8e145d44d9493f4201555d3a1087edf Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>