Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4653: fix sticky config variable problem ......................................................................
IMPALA-4653: fix sticky config variable problem Previously we could get a developer's shell into a bad state where a value of a config variable from a previous impala-config.sh version would override the value from the new impala-config.sh version. This change adds a new mechanism to override settings locally by adding settings to impala-config-local.sh. This alternative approach is more robust, because the config variables will be reset to the intended values when impala-config.sh is re-sourced. impala-config-branch.sh can also be used to override settings in a version-controlled way, e.g. to support having different settings for different branches. I did not convert all variables to use this approach, since many people and Jenkins jobs depend on setting these variables from the environment. The remaining "sticky" variables are ones where default values should not change frequently, e.g. source directory locations and build settings. Change-Id: I930e2ca825142428d17a6981c77534ab0c8e3489 Reviewed-on: http://gerrit.cloudera.org:8080/5545 Reviewed-by: Matthew Jacobs <m...@cloudera.com> Tested-by: Impala Public Jenkins --- M .gitignore A bin/impala-config-branch.sh M bin/impala-config.sh 3 files changed, 137 insertions(+), 96 deletions(-) Approvals: Impala Public Jenkins: Verified Matthew Jacobs: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I930e2ca825142428d17a6981c77534ab0c8e3489 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
