Matthew Jacobs has posted comments on this change.

Change subject: Release note updates for Impala 2.8
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/5668/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

PS1, Line 91: not
typo


PS1, Line 111:  This is a change from early experimental versions of Impala + 
Kudu, where columns
             :             had the <codeph>NOT NULL</codeph> attribute by 
default.
I don't think this is correct. AFAIK the default behavior is the same and we 
have nullable cols by default


http://gerrit.cloudera.org:8080/#/c/5668/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

PS1, Line 90: )
move left?


PS1, Line 103: rev="IMPALA-1788"
move to p?


PS1, Line 238: involving a small number of rows
needed?


PS1, Line 247: lineage metadata is not generated for
             :                 <codeph>UPDATE</codeph> and 
<codeph>DELETE</codeph> operations on Kudu tables.
does insert work for kudu tables? check with dimitris


PS1, Line 253: Currently, Kudu tables have limited support for Sentry:
dimitris should review

we may call out that access thru other engines to kudu doesnt respect this


-- 
To view, visit http://gerrit.cloudera.org:8080/5668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c47f422e509cec6d3eb8aaa82294b584f393aed
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jruss...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.k...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to