Dan Hecht has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files ......................................................................
Patch Set 9: Code-Review+2 (2 comments) If you want to add the config values to the message, I can take another look. Otherwise, this looks okay. Did you run the S3 tests to make sure it works? http://gerrit.cloudera.org:8080/#/c/5400/8/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: PS8, Line 319: locksize (fs.s3a. > Done. Grep for GetHadoopConfig(). If you think it's overkill to add this info, it's okay to not do it. http://gerrit.cloudera.org:8080/#/c/5400/8/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: PS8, Line 327: "Parquet file '%s': Ro > I could not find filesystem_prefix() method. Oops, the python method is get_fs_path(). But, you're right since this is used for comparing with the error string, you need it to be the qualified path so NAMENODE works. -- To view, visit http://gerrit.cloudera.org:8080/5400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf48d978383d73efdade733a892e795ebd53c76a Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
