Matthew Jacobs has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu ......................................................................
Patch Set 5: Code-Review+2 (2 comments) Please just address my comment about arbitrary, otherwise looks good- thanks! http://gerrit.cloudera.org:8080/#/c/5646/5/docs/topics/impala_delete.xml File docs/topics/impala_delete.xml: PS5, Line 42: arbitrary this makes it sound like it's random. how about 'a number of rows' or 'one or more' rows? http://gerrit.cloudera.org:8080/#/c/5646/4/docs/topics/impala_upsert.xml File docs/topics/impala_upsert.xml: PS4, Line 41: <indexterm audience="hidden">UPSERT statement</indexterm> : Acts as a combination of the <codeph>INSERT</codeph> : and <codeph>UPDATE</codeph> statements. > It is pretty well-known for people familiar with UPSERT (i.e. implied by th It's just kind of ambiguous as to what that means. Anyway I don't feel that strongly. -- To view, visit http://gerrit.cloudera.org:8080/5646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60512b7957fb53d86d3123a4f1d46fbb355f4665 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Ambreen Kazi <ambreen.k...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
