Marcel Kornacker has posted comments on this change. Change subject: Impala ABM / LZCNT support ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5821/1/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 98: static inline uint32_t RoundUpToPowerOfTwoNoHw32(uint32_t v) { we don't do unsigned arithmetic, unless we're dealing with bit vectors (but then rounding doesn't make sense). Line 119: static inline uint32_t RoundUpToPowerOfTwo32(uint32_t v) { same here -- To view, visit http://gerrit.cloudera.org:8080/5821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f6a465ab4a9ee4f582847f8e211a779bdede3d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
