Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5815/1//COMMIT_MSG Commit Message: Line 7: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of > describe the fix not the bug: Done http://gerrit.cloudera.org:8080/#/c/5815/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: Line 1279: uncacheTable(removedDb.getTable(tableName)); > It's a little tricky to figure out, but I think we may have to lock these t This is quite tricky. Keep in mind that we perform these operations on the deleted table objects. So the question is whether we correctly handle dropping a table and at the same time altering it. The answer I believe is no. The former operation uses the metastoreDdlLock_ while the latter is protected by the table lock. In theory, and assuming we had proper hierarchical locking, no concurrent access should be allowed on these tables as it would require, in the least, a read lock on the db to be dropped. We could acquire the lock on the dropped tables but, I'd rather not do it in this patch. http://gerrit.cloudera.org:8080/#/c/5815/1/fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java File fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java: Line 163: org.apache.hadoop.hive.metastore.api.Partition part) throws ImpalaException { > tab Done http://gerrit.cloudera.org:8080/#/c/5815/1/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: Line 212: """The DROP DATABASE CASCADE should properly drop all impacted cache directives > Remove "The" Done Line 213: IMPALA-2518""" > use IMPALA-2518 as a prefix to comment (like we typically do) Done Line 215: # Creates `cachedb` database with some cached tables and partitions > Populates the 'cachedb' database... Done -- To view, visit http://gerrit.cloudera.org:8080/5815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83ef5a33e06728c2b3f833a0309d9da64dce7b88 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
