Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5840/2/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: PS2, Line 317: KUDU_COL_MISMATCH nit: maybe call this 'KUDU_NUM_COLS_MISMATCH', else it sounds like it could be a type mismatch too. http://gerrit.cloudera.org:8080/#/c/5840/2/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: PS2, Line 162: cursor.execute("SELECT * FROM %s.foo" % (unique_database)) : assert cursor.fetchall() == [(0, )] Should we assert that the warning is printed here too? PS2, Line 191: Column 's' not found in kudu table impala::test_kudu_col_removed This is not the same as the 'KUDU_COL_MISMATCH' error. Does that mean this gets caught earlier on? In which case, does that extra code comparing the expected number of columns with the actual number of columns actually help? -- To view, visit http://gerrit.cloudera.org:8080/5840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d43f5bb9811e728ad592933066d006c8fb4553a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
