Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types ......................................................................
Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 5510: Decimal8Value(4) Probably doesn't matter but this can be Decimal4Value(), right ? Same below. PS2, Line 5585: Decimal8Value Decimal4Value() ? -- To view, visit http://gerrit.cloudera.org:8080/5959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
