Michael Ho has posted comments on this change. Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5989/1//COMMIT_MSG Commit Message: PS1, Line 9: This change enables decimal_v2 for casting to decimal except : for cases which involve rounding/truncation > What about for DECIMAL to DECIMAL casting that does involve rounding? Is th Yes. Please see test_underflow(). -- To view, visit http://gerrit.cloudera.org:8080/5989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf2c8c9d360ad92cbdc5ce902ee742ec4408a8a3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
