Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init ......................................................................
Patch Set 1: > > I'm not too clear on how this CMAKE option would get affected > > because of this: > > https://github.com/apache/incubator-impala/blob/b3cbc960a7e4beebf6cb9076a02b3513bb0b2954/be/src/util/CMakeLists.txt#L21 > > > > Do you think this needs to change? > > I don't think it should matter much but I suspect we can probably > just remove this now. It looks like it's been here for 4years, and > was added to handle differences between openssl libraries that > might be dynamically linked at runtime. Now that we have an impala > toolchain with openssl, I don't think this is still relevant. > > I think Henry can confirm as it looks like he was involved in the > initial discussion around adding it. Well, after looking more, it looks to me like (a) the toolchain openssl doesn't actually get used in Impala (just the toolchain lib build) so my previous comment may not be valid. On the other hand, it looks to me like Kudu doesn't build Squeasel with this flag so it might not be necessary anyway. -- To view, visit http://gerrit.cloudera.org:8080/6006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d28f2a5391b8a7d39a50002ff1d96ef3d927567 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: No
